Treat pyhive as a synchronous package and add a regression test#151
Open
hedgert wants to merge 1 commit into
Open
Treat pyhive as a synchronous package and add a regression test#151hedgert wants to merge 1 commit into
hedgert wants to merge 1 commit into
Conversation
Treat both `pyhive` and `pyhiveapi` as synchronous packages. Previously `import pyhive` exposed the asynchronous API because `src/__init__.py` only checked for `__name__ == "pyhiveapi"`. Add a regression test to verify that `pyhive` exposes the synchronous `HiveAuth` and `HiveApi` classes. The test fails without this change and passes with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import pyhive currently exposes the asynchronous API because src/init.py only checks for name == "pyhiveapi".
This change treats both pyhive and pyhiveapi as synchronous packages so that import pyhive exposes the synchronous HiveAuth and HiveApi classes.
Testing
Added a regression test verifying that pyhive exposes the synchronous classes.
Confirmed the new test fails without this change.
Confirmed the test passes with this change.
Ran the existing test suite successfully.